I think the desktop version might need to wait for at least two stable versions. Currently, there are still some other subgraph features under development.
I've noticed you can't see a preview inside the subgraph, unless you are inside the subgraph when the ksampler starts. Everything Everywhere seems to me working for me outside the subgraphs, and that works fine as you can create an input on the subgraph for everything everywhere, but kj's get/set has been pretty unreliable although he does seem to be updating regularly.
KJ's Get/Set uses frontend data, not backend data, which is why Get/Set doesn't work correctly because it's not displayed on the Canvas and doesn't actually have links.
A different implementation of Get/Set is needed when the data is processed by the backend and linked to the backend. At the same time, it should be taken into account that subgraphs allow storing global data about nodes during the entire workflow, so that Get/Set can be implemented
More recent updates seem to have fixed the issues, and currently I am finding KJ set/get more reliable than anything everywhere which keep dropping the links. Although now we have previews, which is pretty awesome, and we can link and show dropdowns on the subgraph node, which has been really nice.
The subgraph shows up in "Add Node"; but, if you have more than one, they all read "New". How can I name the subgraph node before it saves? I know I can change the name on an open project. But, if I want to import the node into a new project, I don't know what that node does.
This would be good but low hanging fruit. Could easily copy/ paste the nodes back out, slow process reconnecting it all but I’d hope for additions to sub graphs and to make sure they work with comfys API for production workflows.
Sorry, the json API export. We've had issue isn the past with those and some nodes liek Anything Everywhere. I'll be testing this out and I may be a little presumptive in assume there may be bugs when trying to run a workflow outside of comfy ui, maybe running a script that links to a persistent server to run a workflow and gather allof my outputs.
If subgraphs are group nodes 10.0, im all in, just curious if that was considered for more advanced production workflows and use cases. Maybe it just works out of the box, again, I was questioning something I hadn't tested yet. Will test.
It should just work. ComfyUI frontend coverts workflows to the API format before queueing it in ComfyUI server by default. Let us know if you run into any issues with the API json export
Most definitely. Btw, kudos to the comfy team for keep it an amazing tool to work with. I didnt mean to throw any shade, the software is fantastic and I and a few others I work with all shouted in excitement when we got the subgraph email. Keep up the great work.
I have a problem where if I save subgraphs and restart ComfyUI, the connections don’t load properly and I get NAN errors.
Has the update been applied to the desktop version? When I checked for updates it says its up to date even tho the git has a different version number.
I think the desktop version might need to wait for at least two stable versions. Currently, there are still some other subgraph features under development.
I've noticed you can't see a preview inside the subgraph, unless you are inside the subgraph when the ksampler starts. Everything Everywhere seems to me working for me outside the subgraphs, and that works fine as you can create an input on the subgraph for everything everywhere, but kj's get/set has been pretty unreliable although he does seem to be updating regularly.
KJ's Get/Set uses frontend data, not backend data, which is why Get/Set doesn't work correctly because it's not displayed on the Canvas and doesn't actually have links.
A different implementation of Get/Set is needed when the data is processed by the backend and linked to the backend. At the same time, it should be taken into account that subgraphs allow storing global data about nodes during the entire workflow, so that Get/Set can be implemented
I noticed that :
- I create a subgraph
- I clone it to have multiple instances, used in different points of the workflow
- then I bypass one of the instances. All the nodes inside the subgraph become bypassed
- but this happens for all instances, not only the one I bypassed, so the workflow is broken
Is this intended? It makes difficult to reuse the same subgraph in different places of the same workflow.
I can fix it by copy and past the subgraph, in which case every instance is a separate subgraph, completely disconnected from each other.
But then if I have to modify part of the subgraph, I have to redo it on every instance.
More recent updates seem to have fixed the issues, and currently I am finding KJ set/get more reliable than anything everywhere which keep dropping the links. Although now we have previews, which is pretty awesome, and we can link and show dropdowns on the subgraph node, which has been really nice.
Right now if I connect an integer property to the inputs of the group, it is made visible to the outside as a widget.
However, that widget cannot be converted into an 'UE connectable widget', like it is possible to do with the standard nodes.
Is there a plan to implement that? The question is because Anything Anywere nodes need a connectable widget to work.
So for instance, if I export properties like 'width', 'height', 'steps', I have 3 integer properties to manage separately.
The subgraph shows up in "Add Node"; but, if you have more than one, they all read "New". How can I name the subgraph node before it saves? I know I can change the name on an open project. But, if I want to import the node into a new project, I don't know what that node does.
部分执行从开始有那个按钮，就不起作用，而是点击后会全部执行，希望修复
请确保使用的是前端 1.24.3 版本及以上
可能是有Custom Node节点的影响。如果禁用所有插件还会出现吗？
This is good!
But are there plans to implement the ability to expand back created subgraphs?
It would be very convenient to be able to return nodes from a subgraph back.
There is a discussion on GitHub about this issue:
https://github.com/Comfy-Org/ComfyUI_frontend/issues/4166
This would be good but low hanging fruit. Could easily copy/ paste the nodes back out, slow process reconnecting it all but I’d hope for additions to sub graphs and to make sure they work with comfys API for production workflows.
What do you mean by work with Comfy’s API?
Sorry, the json API export. We've had issue isn the past with those and some nodes liek Anything Everywhere. I'll be testing this out and I may be a little presumptive in assume there may be bugs when trying to run a workflow outside of comfy ui, maybe running a script that links to a persistent server to run a workflow and gather allof my outputs.
If subgraphs are group nodes 10.0, im all in, just curious if that was considered for more advanced production workflows and use cases. Maybe it just works out of the box, again, I was questioning something I hadn't tested yet. Will test.
It should just work. ComfyUI frontend coverts workflows to the API format before queueing it in ComfyUI server by default. Let us know if you run into any issues with the API json export
Most definitely. Btw, kudos to the comfy team for keep it an amazing tool to work with. I didnt mean to throw any shade, the software is fantastic and I and a few others I work with all shouted in excitement when we got the subgraph email. Keep up the great work.
None taken so keep sending up questions and feedback :). They are extremely welcome!